Skip to content

Implement Float Calculations - #43

Open
pisum-sativum wants to merge 3 commits into
kathan-majithia:mainfrom
pisum-sativum:implement-float-calculations
Open

Implement Float Calculations#43
pisum-sativum wants to merge 3 commits into
kathan-majithia:mainfrom
pisum-sativum:implement-float-calculations

Conversation

@pisum-sativum

@pisum-sativum pisum-sativum commented Jun 23, 2026

Copy link
Copy Markdown

Description

Resolves #4

This PR introduces the float calculation module required for non-critical activities. Based on the calculated Early Start (ES), Early Finish (EF), Late Start (LS), and Late Finish (LF), the module can now calculate:

  • Total Float (TF)
  • Free Float (FF)
  • Independent Float (IF)

Changes Made:

  • Added total_float, free_float, and independent_float attributes to the Node class.
  • Implemented calculate_floats() in CriticalPathMethod which processes the network logic according to standard CPM/PERT formulas.
  • Added get_non_critical_floats() in CriticalPathMethod to cleanly extract and return these float metrics exclusively for non-critical activities.
  • Maintained the existing library logic without introducing unnecessary changes or dependencies.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@pisum-sativum

pisum-sativum commented Jun 23, 2026

Copy link
Copy Markdown
Author

@kathan-majithia I have done the necessary changes kindly check and merge and also add the gssoc and gssoc:approved tags.

@kathan-majithia

Copy link
Copy Markdown
Owner

Great @pisum-sativum , also add the display float in the network_summary function.

@pisum-sativum

pisum-sativum commented Jun 26, 2026

Copy link
Copy Markdown
Author

Great @pisum-sativum , also add the display float in the network_summary function.

@kathan-majithia I have done the necessary changes kindly check and merge with gssoc and gssoc:approved tags pls.

@kathan-majithia

Copy link
Copy Markdown
Owner

Display all types of float properly, for each node as well as final values.

@pisum-sativum

Copy link
Copy Markdown
Author

Display all types of float properly, for each node as well as final values.

@kathan-majithia I have done the required changes pls check and merge with gssoc and gssoc:approved tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Float Calculations

2 participants