feat: add export() method for PNG/SVG/PDF diagram output - #46
Open
dharapandya85 wants to merge 2 commits into
Open
feat: add export() method for PNG/SVG/PDF diagram output#46dharapandya85 wants to merge 2 commits into
dharapandya85 wants to merge 2 commits into
Conversation
Author
|
@kathan-majithia , please review. |
Owner
|
Great @dharapandya85, but why two gantt charts are exported ? Also keep the logic simple, like what to export and in what format to export in export() or save() function. |
Author
|
@kathan-majithia , removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #21
this PR does:
display_network()andgenerate_gantt_chart()to extract figure-building logic into_build_network_figure()and_build_gantt_figure()private builders.png, .svg,and.pdf