Fix(Regions): setOptions type (#3972)

katspaugh · Dec 25, 2024 · 404f7ea · 404f7ea
1 parent 7008eb3
commit 404f7ea
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/plugins/regions.ts b/src/plugins/regions.ts
@@ -366,7 +366,11 @@ class SingleRegion extends EventEmitter<RegionEvents> implements Region {
   }
 
   /** Update the region's options */
-  public setOptions(options: Omit<RegionParams, 'minLength' | 'maxLength'>) {
+  public setOptions(
+    options: Partial<
+      Pick<RegionParams, 'color' | 'start' | 'end' | 'drag' | 'content' | 'id' | 'resize' | 'resizeStart' | 'resizeEnd'>
+    >,
+  ) {
     if (options.color) {
       this.color = options.color
       this.element.style.backgroundColor = this.color
@@ -607,10 +611,7 @@ class RegionsPlugin extends BasePlugin<RegionsPluginEvents, RegionsPluginOptions
 
     this.subscriptions.push(...regionSubscriptions)
 
-    // A small timeout to allow internal events to be emitted first
-    setTimeout(() => {
-      this.emit('region-created', region)
-    }, 0)
+    this.emit('region-created', region)
   }
 
   /** Create a region with given parameters */