Type minimap container as optional #3387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the minimap option
container
optional.In the options passed to
MinimapPlugin.create()
, thecontainer
option is optional. However, the typing has it set as required. Not including it resulted in the TypeScript errorTS2345: Argument of type {} is not assignable to parameter of type MinimapPluginOptions. Property container is missing in type {} but required in type WaveSurferOptions.
This PR removes that error since the option is not required, and in fact, the minimap code handles the case wherecontainer
is undefined.The previous workaround was to coerce the typing:
MinimapPlugin.create({} as MinimapPluginOptions)
Checklist