Feat: Add timeline-notch-{mode} to part #3401
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The current timeline plugin creates elements with
div[part=timeline-notch]
. There are currently three different types of timeline notches: primary, secondary, and unlabeled tickmarks. This PR appends one of the following to each notch element part:timeline-notch-primary
timeline-notch-seconary
timeline-notch-tick
Resolves #
Implementation details
Updated
plugins/timeline.ts
to set thepart
attribute.How to test it
Inspect the timeline
div
tags in the examples section. All notch elements should contain one of the following:part="timeline-notch timeline-notch-primary"
part="timeline-notch timeline-notch-secondary"
part="timeline-notch timeline-notch-tick"
Screenshots
Checklist