Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add timeline-notch-{mode} to part #3401

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

jason-whitted
Copy link
Contributor

Short description

The current timeline plugin creates elements with div[part=timeline-notch]. There are currently three different types of timeline notches: primary, secondary, and unlabeled tickmarks. This PR appends one of the following to each notch element part:

  • timeline-notch-primary
  • timeline-notch-seconary
  • timeline-notch-tick

Resolves #

Implementation details

Updated plugins/timeline.ts to set the part attribute.

How to test it

Inspect the timeline div tags in the examples section. All notch elements should contain one of the following:

  • part="timeline-notch timeline-notch-primary"
  • part="timeline-notch timeline-notch-secondary"
  • part="timeline-notch timeline-notch-tick"

Screenshots

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jason-whitted
Copy link
Contributor Author

jason-whitted commented Dec 12, 2023

NOTE: I had a bit of trouble getting this repository to run locally.

yarn start runs npm run build:dev & npm run serve, but at least on my computer the build:dev script is awaiting changes and the yarn serve command never runs.

I could manually run the two commands in two different bash terminals to get localhost:9090 running, but most of the examples failed to run locally. They would throw Container not found errors.

I didn't want to let my local dev environment issues get in the way of submitting this PR though. Let me know if you need anything else from me. Thanks for the excellent library!

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@katspaugh katspaugh merged commit 83a0909 into katspaugh:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants