Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: re-throw error on load #3586

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Refactor: re-throw error on load #3586

merged 3 commits into from
Mar 9, 2024

Conversation

katspaugh
Copy link
Owner

@katspaugh katspaugh commented Mar 9, 2024

Short description

A follow-up on #3532.

Implementation details

  • The error event handler now takes an Error object
  • Async fetching/decoding errors in the constructor are now caught and emitted as an error event.
  • Calling load and loadBlob will still result in a rejected promise on error (it was swallowed in the original PR), while also emitting an error event.
  • Remove a breaking blob check.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

cloudflare-workers-and-pages bot commented Mar 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2f6a2e0
Status: ✅  Deploy successful!
Preview URL: https://06b59f86.wavesurfer-js.pages.dev
Branch Preview URL: https://error-event.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 2301646 into main Mar 9, 2024
4 checks passed
@katspaugh katspaugh deleted the error-event branch March 9, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant