Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: draggable touch delay #3616

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Fix: draggable touch delay #3616

merged 2 commits into from
Mar 31, 2024

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3613

Adds a delay before triggering a drag gesture on mobile.

Implementation details

I've refactored and optimized the makeDraggable function, and added a touch delay option to prevent accidental dragging on mobile.

Verified

This commit was signed with the committer’s verified signature.
Copy link

cloudflare-workers-and-pages bot commented Mar 31, 2024

Deploying wavesurfer-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3dea24c
Status: ✅  Deploy successful!
Preview URL: https://8c32ab1a.wavesurfer-js.pages.dev
Branch Preview URL: https://draggable.wavesurfer-js.pages.dev

View logs

Verified

This commit was signed with the committer’s verified signature.
@katspaugh katspaugh merged commit 74308ba into main Mar 31, 2024
2 of 3 checks passed
@katspaugh katspaugh deleted the draggable branch March 31, 2024 11:27
@katspaugh katspaugh mentioned this pull request Apr 3, 2024
2 tasks
katspaugh added a commit that referenced this pull request Apr 13, 2024

Verified

This commit was signed with the committer’s verified signature.
This reverts commit 74308ba.
katspaugh added a commit that referenced this pull request Apr 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This reverts commit 74308ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dragToSeek on mobile causes whole page to be unresponsive
1 participant