Some fixes for viewer role #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #144 +/- ##
===========================================
- Coverage 39.12% 13.63% -25.50%
===========================================
Files 228 226 -2
Lines 27141 27072 -69
Branches 3887 3880 -7
===========================================
- Hits 10620 3691 -6929
- Misses 15662 22782 +7120
+ Partials 859 599 -260
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 140 files with indirect coverage changes |
MWargelin
force-pushed
the
fix/viewer-role
branch
2 times, most recently
from
e45ee4c to
c04c5a4
Compare
MWargelin
force-pushed
the
fix/viewer-role
branch
5 times, most recently
from
a04545a to
d1e6ad5
Compare
Pre-existing viewer role could not log in. Fix login by modifying what is considered an "adminable instance" for a user and by adding access to wagtail admin as permission for the viewer role.
tituomin
force-pushed
the
fix/viewer-role
branch
from
d1e6ad5 to
fed8130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frustratingly one test is still failing, even though judging by manual tests everything works fine. After fixing that this PR is ready to be merged and a good stepping stone towards the viewer role, even though the role still needs some work.