Add a Python implementation of the 3D black hole visualizer#41
Open
anshjaiswal12 wants to merge 1 commit into
Open
Add a Python implementation of the 3D black hole visualizer#41anshjaiswal12 wants to merge 1 commit into
anshjaiswal12 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this change
This project is already a very interesting and popular black hole visualization, so I thought it would be useful to provide a Python version of the same idea as an additional option for contributors and users.
The goal of this PR is not to replace the existing C++ code. Instead, it adds a Python implementation of the same 3D visualizer for people who:
What the Python implementation includes
Structure
The new code lives under python/ to keep the contribution isolated and easy to review:
Python requirements
Recommended Python version: 3.10+
Dependencies:
Validation
Future work
I also plan to continue improving the Python version and try adding more black hole-related features over time.
If this direction looks good, I would be happy to build on it in follow-up contributions as well.