fixed get_descendants #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed how get_descendants works * Switched out search function to test performance impact * Switched out search function to test performance impact * Switched out search function to test performance impact * Switched out search function to test performance impact * Search change updates * Search change updates * Search change updates * Search change updates * Search change updates * Search change updates * Search change updates * Temporary performance check * Added paging passthrough for descendants and changing search
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 21.92% 20.87% -1.05%
==========================================
Files 3 3
Lines 260 273 +13
Branches 48 50 +2
==========================================
Hits 57 57
- Misses 203 216 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
get_descendantsonly returns itself. I made get_desendants behave more likeget_tree_memberswhich means it now returns all groups that are lower on the tree than the parent.One other thing to note is that I also swapped out the search for get_children. The new search means the result list no longer needs to be built manually, let me know what your thoughts are on that change. I can revert it to the previous method or I can go through and update all of the functions to use the new search method.