Skip to content

Enable containers 0.7 (ghc 9.10) - #117

Closed
edsko wants to merge 1 commit into
kazu-yamamoto:mainfrom
edsko:edsko/ghc-9.10
Closed

Enable containers 0.7 (ghc 9.10)#117
edsko wants to merge 1 commit into
kazu-yamamoto:mainfrom
edsko:edsko/ghc-9.10

Conversation

@edsko

@edsko edsko commented May 29, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@kazu-yamamoto
kazu-yamamoto self-requested a review May 29, 2024 23:26
kazu-yamamoto
kazu-yamamoto requested changes May 29, 2024
View reviewed changes

@kazu-yamamoto kazu-yamamoto left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's better to remove the upper bound in this case.

@edsko

edsko commented May 30, 2024

Copy link
Copy Markdown
Collaborator Author

I don't understand..?

@edsko

edsko commented May 30, 2024

Copy link
Copy Markdown
Collaborator Author

I mean, I can remove the upper bound if you like, or set it to something really high (otherwise Hackage will not accept the package at all), but it's not an automatic given that http2 will continue to work with each new major version (which, by definition, can introduce breaking changes)?

@kazu-yamamoto

kazu-yamamoto commented May 30, 2024

Copy link
Copy Markdown
Owner

I have suffered from the major version up of bytestring.
My packages do not hit the breaking changes but I needed to modify their cabal files.
I guess that containers follows the same pattern.
So, I would like to simply remove the upper bound.

@edsko

edsko commented May 30, 2024

Copy link
Copy Markdown
Collaborator Author

Removing the upper bound altogether will cause Hackage to reject the package. Will I set it to >= 0.6 < 1, similar to what you do with base (>= 4.9 < 5)?

@kazu-yamamoto

kazu-yamamoto commented May 30, 2024

Copy link
Copy Markdown
Owner

I would like to remove the upper bound only for containers.
I don't think the change results in a reject from Hackage.
But you don't like this approach, >= 0.6 < 1 is acceptable.

@edsko

edsko commented May 30, 2024

Copy link
Copy Markdown
Collaborator Author

Oh, maybe you are right, I just checked, and it's a warning only...? 🤔 Only if it is base it is an actual reject..? Ok, I learned something new today :) Will fix.

@edsko
edsko force-pushed the edsko/ghc-9.10 branch from f7e74f8 to 5e36db4 Compare May 30, 2024 07:44
@kazu-yamamoto
kazu-yamamoto self-requested a review June 12, 2024 00:22
kazu-yamamoto
kazu-yamamoto approved these changes Jun 12, 2024
View reviewed changes

@kazu-yamamoto kazu-yamamoto left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM

kazu-yamamoto added a commit that referenced this pull request Jun 12, 2024
@kazu-yamamoto
Merge PR #117
68ada02
@kazu-yamamoto

kazu-yamamoto commented Jun 12, 2024

Copy link
Copy Markdown
Owner

Rebased and merged.

@edsko
edsko deleted the edsko/ghc-9.10 branch August 28, 2024 06:51
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2025
@depressed-pho
www/hs-http2: update to http2-5.3.9
e0b760a 
# ChangeLog for http2

## 5.3.9

* Using `ThreadManager` of `time-manager`.

## 5.3.8

* `forkManagedTimeout` ensures that only one asynchronous exception is
  thrown. Fixing the thread leak via `Weak ThreadId` and `modifyTVar'`.
  [#156](kazu-yamamoto/http2#156)

## 5.3.7

* Using `withHandle` of time-manager.
* Getting `Handle` for each thread.
* Providing allocSimpleConfig' to enable customizing WAI tiemout manager.
* Monitor option (-m) for h2c-client and h2c-server.

## 5.3.6

* Making `runIO` friendly with the new synchronism mechanism.
  [#152](kazu-yamamoto/http2#152)
* Re-throwing asynchronous exceptions to prevent thread leak.
* Simplifying the synchronism mechanism between workers and the sender.
  [#148](kazu-yamamoto/http2#148)

## 5.3.5

* Using `http-semantics` v0.3.
* Deprecating `numberOfWorkers`.
* Removing `unliftio`.
* Avoid `undefined` in client.
  [#146](kazu-yamamoto/http2#146)

## 5.3.4

* Support stream cancellation
  [#142](kazu-yamamoto/http2#142)

## 5.3.3

* Enclosing IPv6 literal authority with square brackets.
  [#143](kazu-yamamoto/http2#143)

## 5.3.2

* Avoid unnecessary empty data frames at end of stream
  [#140](kazu-yamamoto/http2#140)
* Removing unnecessary API from ServerIO

## 5.3.1

* Fix treatment of async exceptions
  [#138](kazu-yamamoto/http2#138)
* Avoid race condition
  [#137](kazu-yamamoto/http2#137)

## 5.3.0

* New server architecture: spawning worker on demand instead of the
  worker pool. This reduce huge numbers of threads for streaming into
  only 2. No API changes but workers do not terminate quicly. Rather
  workers collaborate with the sender after queuing a response and
  finish after all response data are sent.
* All threads are labeled with `labelThread`. You can see them by
  `listThreas` if necessary.

## 5.2.6

* Recover rxflow on closing.
  [#126](kazu-yamamoto/http2#126)
* Fixing ClientSpec for stream errors.
* Allowing negative window. (h2spec http2/6.9.2)
* Update for latest http-semantics
  [#122](kazu-yamamoto/http2#124)

## 5.2.5

* Setting peer initial window size properly.
  [#123](kazu-yamamoto/http2#123)

## 5.2.4

* Update for latest http-semantics
  [#122](kazu-yamamoto/http2#122)
* Measuring performance concurrently for h2c-client

## 5.2.3

* Update for latest http-semantics
  [#120](kazu-yamamoto/http2#120)
* Enable containers 0.7 (ghc 9.10)
  [#117](kazu-yamamoto/http2#117)

## 5.2.2

* Mark final chunk as final
  [#116](kazu-yamamoto/http2#116)
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
@depressed-pho
www/hs-http2: update to http2-5.3.9
41b8d8e 
# ChangeLog for http2

## 5.3.9

* Using `ThreadManager` of `time-manager`.

## 5.3.8

* `forkManagedTimeout` ensures that only one asynchronous exception is
  thrown. Fixing the thread leak via `Weak ThreadId` and `modifyTVar'`.
  [NetBSD#156](kazu-yamamoto/http2#156)

## 5.3.7

* Using `withHandle` of time-manager.
* Getting `Handle` for each thread.
* Providing allocSimpleConfig' to enable customizing WAI tiemout manager.
* Monitor option (-m) for h2c-client and h2c-server.

## 5.3.6

* Making `runIO` friendly with the new synchronism mechanism.
  [NetBSD#152](kazu-yamamoto/http2#152)
* Re-throwing asynchronous exceptions to prevent thread leak.
* Simplifying the synchronism mechanism between workers and the sender.
  [NetBSD#148](kazu-yamamoto/http2#148)

## 5.3.5

* Using `http-semantics` v0.3.
* Deprecating `numberOfWorkers`.
* Removing `unliftio`.
* Avoid `undefined` in client.
  [NetBSD#146](kazu-yamamoto/http2#146)

## 5.3.4

* Support stream cancellation
  [NetBSD#142](kazu-yamamoto/http2#142)

## 5.3.3

* Enclosing IPv6 literal authority with square brackets.
  [NetBSD#143](kazu-yamamoto/http2#143)

## 5.3.2

* Avoid unnecessary empty data frames at end of stream
  [NetBSD#140](kazu-yamamoto/http2#140)
* Removing unnecessary API from ServerIO

## 5.3.1

* Fix treatment of async exceptions
  [NetBSD#138](kazu-yamamoto/http2#138)
* Avoid race condition
  [NetBSD#137](kazu-yamamoto/http2#137)

## 5.3.0

* New server architecture: spawning worker on demand instead of the
  worker pool. This reduce huge numbers of threads for streaming into
  only 2. No API changes but workers do not terminate quicly. Rather
  workers collaborate with the sender after queuing a response and
  finish after all response data are sent.
* All threads are labeled with `labelThread`. You can see them by
  `listThreas` if necessary.

## 5.2.6

* Recover rxflow on closing.
  [NetBSD#126](kazu-yamamoto/http2#126)
* Fixing ClientSpec for stream errors.
* Allowing negative window. (h2spec http2/6.9.2)
* Update for latest http-semantics
  [NetBSD#122](kazu-yamamoto/http2#124)

## 5.2.5

* Setting peer initial window size properly.
  [NetBSD#123](kazu-yamamoto/http2#123)

## 5.2.4

* Update for latest http-semantics
  [NetBSD#122](kazu-yamamoto/http2#122)
* Measuring performance concurrently for h2c-client

## 5.2.3

* Update for latest http-semantics
  [NetBSD#120](kazu-yamamoto/http2#120)
* Enable containers 0.7 (ghc 9.10)
  [NetBSD#117](kazu-yamamoto/http2#117)

## 5.2.2

* Mark final chunk as final
  [NetBSD#116](kazu-yamamoto/http2#116)
jperkin pushed a commit to TritonDataCenter/pkgsrc that referenced this pull request May 14, 2026
@depressed-pho
www/hs-http2: update to http2-5.3.9
8719bb3 
# ChangeLog for http2

## 5.3.9

* Using `ThreadManager` of `time-manager`.

## 5.3.8

* `forkManagedTimeout` ensures that only one asynchronous exception is
  thrown. Fixing the thread leak via `Weak ThreadId` and `modifyTVar'`.
  [#156](kazu-yamamoto/http2#156)

## 5.3.7

* Using `withHandle` of time-manager.
* Getting `Handle` for each thread.
* Providing allocSimpleConfig' to enable customizing WAI tiemout manager.
* Monitor option (-m) for h2c-client and h2c-server.

## 5.3.6

* Making `runIO` friendly with the new synchronism mechanism.
  [#152](kazu-yamamoto/http2#152)
* Re-throwing asynchronous exceptions to prevent thread leak.
* Simplifying the synchronism mechanism between workers and the sender.
  [#148](kazu-yamamoto/http2#148)

## 5.3.5

* Using `http-semantics` v0.3.
* Deprecating `numberOfWorkers`.
* Removing `unliftio`.
* Avoid `undefined` in client.
  [#146](kazu-yamamoto/http2#146)

## 5.3.4

* Support stream cancellation
  [#142](kazu-yamamoto/http2#142)

## 5.3.3

* Enclosing IPv6 literal authority with square brackets.
  [#143](kazu-yamamoto/http2#143)

## 5.3.2

* Avoid unnecessary empty data frames at end of stream
  [#140](kazu-yamamoto/http2#140)
* Removing unnecessary API from ServerIO

## 5.3.1

* Fix treatment of async exceptions
  [#138](kazu-yamamoto/http2#138)
* Avoid race condition
  [#137](kazu-yamamoto/http2#137)

## 5.3.0

* New server architecture: spawning worker on demand instead of the
  worker pool. This reduce huge numbers of threads for streaming into
  only 2. No API changes but workers do not terminate quicly. Rather
  workers collaborate with the sender after queuing a response and
  finish after all response data are sent.
* All threads are labeled with `labelThread`. You can see them by
  `listThreas` if necessary.

## 5.2.6

* Recover rxflow on closing.
  [#126](kazu-yamamoto/http2#126)
* Fixing ClientSpec for stream errors.
* Allowing negative window. (h2spec http2/6.9.2)
* Update for latest http-semantics
  [#122](kazu-yamamoto/http2#124)

## 5.2.5

* Setting peer initial window size properly.
  [#123](kazu-yamamoto/http2#123)

## 5.2.4

* Update for latest http-semantics
  [#122](kazu-yamamoto/http2#122)
* Measuring performance concurrently for h2c-client

## 5.2.3

* Update for latest http-semantics
  [#120](kazu-yamamoto/http2#120)
* Enable containers 0.7 (ghc 9.10)
  [#117](kazu-yamamoto/http2#117)

## 5.2.2

* Mark final chunk as final
  [#116](kazu-yamamoto/http2#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edsko @kazu-yamamoto