Merged
Conversation
Note: this is backwards incompatible but unlikely to cause issues * Minio collapses multiple slashes into a single slash in bucket/key paths * CEPH does not * Posix files systems more or less collapse them Putting multiple slashes in an object is weird anyway, so just throw an error on any paths with multiple slashes. The current code already does this for internal multi-slashes in keys, just do it for the start of keys as well rather than silently collapsing them. Also add the checksum algorithm to the file uploader test fixture
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 53.29% 53.33% +0.03%
==========================================
Files 69 69
Lines 5965 5972 +7
==========================================
+ Hits 3179 3185 +6
- Misses 2786 2787 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tianhao-Gu
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is backwards incompatible but unlikely to cause issues
Putting multiple slashes in an object is weird anyway, so just throw an error on any paths with multiple slashes. The current code already does this for internal multi-slashes in keys, just do it for the start of keys as well rather than silently collapsing them.
Also add the checksum algorithm to the file uploader test fixture