Skip to content

Reject > 1 bucket / key separator#576

Merged
MrCreosote merged 1 commit intomainfrom
dev-service
Mar 28, 2026
Merged

Reject > 1 bucket / key separator#576
MrCreosote merged 1 commit intomainfrom
dev-service

Conversation

@MrCreosote
Copy link
Copy Markdown
Member

Note: this is backwards incompatible but unlikely to cause issues

  • Minio collapses multiple slashes into a single slash in bucket/key paths
  • CEPH does not
  • Posix files systems more or less collapse them

Putting multiple slashes in an object is weird anyway, so just throw an error on any paths with multiple slashes. The current code already does this for internal multi-slashes in keys, just do it for the start of keys as well rather than silently collapsing them.

Also add the checksum algorithm to the file uploader test fixture

Note: this is backwards incompatible but unlikely to cause issues

* Minio collapses multiple slashes into a single slash in bucket/key
paths
* CEPH does not
* Posix files systems more or less collapse them

Putting multiple slashes in an object is weird anyway, so just throw an
error on any paths with multiple slashes. The current code already does
this for internal multi-slashes in keys, just do it for the start of
keys as well rather than silently collapsing them.

Also add the checksum algorithm to the file uploader test fixture
@MrCreosote MrCreosote requested a review from Tianhao-Gu March 27, 2026 19:42
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.33%. Comparing base (9fac477) to head (9441195).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   53.29%   53.33%   +0.03%     
==========================================
  Files          69       69              
  Lines        5965     5972       +7     
==========================================
+ Hits         3179     3185       +6     
- Misses       2786     2787       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit b951190 into main Mar 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants