Merged
Conversation
minio.get_object() initiates a client close before returning the object data, which means obj["Body"].read() may or may not fail if the read occurs after the client is closed. Get rid of get_object() and use the client directly in the tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 53.33% 53.33%
=======================================
Files 69 69
Lines 5975 5975
=======================================
Hits 3187 3187
Misses 2788 2788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tianhao-Gu
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minio.get_object() initiates a client close before returning the object data, which means obj["Body"].read() may or may not fail if the read occurs after the client is closed.
Get rid of get_object() and use the client directly in the tests