Skip to content

Fix flaky presigned upload tests#579

Merged
MrCreosote merged 1 commit intomainfrom
dev-service
Mar 30, 2026
Merged

Fix flaky presigned upload tests#579
MrCreosote merged 1 commit intomainfrom
dev-service

Conversation

@MrCreosote
Copy link
Copy Markdown
Member

minio.get_object() initiates a client close before returning the object data, which means obj["Body"].read() may or may not fail if the read occurs after the client is closed.

Get rid of get_object() and use the client directly in the tests

minio.get_object() initiates a client close before returning the object
data, which means obj["Body"].read() may or may not fail if the read
occurs after the client is closed.

Get rid of get_object() and use the client directly in the tests
@MrCreosote MrCreosote requested a review from Tianhao-Gu March 30, 2026 16:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.33%. Comparing base (b8dff75) to head (861725f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files          69       69           
  Lines        5975     5975           
=======================================
  Hits         3187     3187           
  Misses       2788     2788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit 29eabe4 into main Mar 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants