PTV-1860: Update Assembly ID to display refs.#13
Open
dakotablair wants to merge 3 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the Assembly ID column was displaying names instead of refs.
The names can be used to determine the ref by using the dataview page, but this could be tedious for sets with many assemblies and also is not the original intention of the app.
It is possible that this bug appeared as a result of some fixes to the narrative interface to refer to objects by name, where another app was relying on the object being referred to by its ref in the narrative interface. New documentation may be needed to direct app developers to access refs in a manner that does not depend on the implementation details of the narrative interface.