Skip to content

change function signature of spades estimator#62

Open
briehl wants to merge 1 commit intokbaseapps:estimatorfrom
briehl:master
Open

change function signature of spades estimator#62
briehl wants to merge 1 commit intokbaseapps:estimatorfrom
briehl:master

Conversation

@briehl
Copy link

@briehl briehl commented Jul 26, 2019

From

{
    use_defaults: boolean,
    SPAdesParams params
}

to just SPAdesParams.

The idea is that just the parameters used by the app should be used by the estimator. Anything outside of that should be handled by the admins.

@briehl briehl requested a review from psdehal July 26, 2019 15:39
@dcchivian
Copy link

@briehl @psdehal do you still care about this being pushed through? @qzzhang has some changes in the next PR that she's going to want to test without complication from another code update, so I'd rather we do this PR separately (if it's still desired).

@bio-boris
Copy link
Contributor

@dcchivian We are holding off for the estimator right now, but lets keep the branch around. This way we can deploy this app by a specific commit and test it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants