-
Notifications
You must be signed in to change notification settings - Fork 0
[#195] Add more metadata to pipeline executions #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@palagdan could you please review ? |
40bbdab to
690b748
Compare
|
@MSattrtand you can merge this when backend is ready |
24412fd to
7899fc4
Compare
blcham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see my comments.
src/pages/ExecutionsPage.tsx
Outdated
| </Link> | ||
| </td> | ||
| <td> | ||
| <Link to={`/script?file=${data.has_executed_function_script_path}`}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After refactoring the backend, this will not work, I guess ...
Resolves partially #195
The executions page is more informative now. The edit button opens the script, where the function or module was executed. Pressing on ID opens the executions JSON.