Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for showing all password in health report #11850

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

shotor
Copy link

@shotor shotor commented Mar 8, 2025

edit: Build is failing on translations, I didn't add these yet because I saw some cli tools that are related to it but unsure how to use it. If this PR is going to be approved, please let me know what the process is to add translations.


Fixes: #5330

I'd like to see my password scores.

The health report only shows scores for weak passwords.

It's possible to add a password strength column to the passwords screen. It shows the strength as a color but unfortunately doesn't display the numeric score value which I'm interested in.

Password policies change over time because of hardware development. It helps to see the numeric scores to more accurately judge which passwords could be improved. And which ones are "degrading" over time.

There were 2 options, (1) to add it as a column to the password screen. (2) add it to the health report.

This PR adds it to the health report. I think it would be good to add it as a column to the password screen as well.

I implemented this feature by adding a new filter called show weak passwords only which defaults to true, which is the default behavior right now. Unchecking it shows all passwords.

Screenshots

Default behavior:

image

After unchecking show weak passwords only filter:

image

Testing strategy

Required 4 characters changed in 1 test module to account for scoreReason and scoreDetails being defined now for Good and Excellent passwords.

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added this to the v2.7.11 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health Check - Option to Show All Entries?
2 participants