Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable extra volume mounts for front end #128

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

donbowman
Copy link
Contributor

@donbowman donbowman commented Feb 15, 2025

This allows adding icons to generic events, e.g. add:

  extraVolumeMounts:
    - mountPath: /app/public/icons/eventc-icon.png 
      name: icons 
     subPath: eventc-icon.png 
  extraVolumes:
    - name: icons
      configMap: 
       name: icons
  

to the frontend section (and make a config map with your icon).

I added the icon config map via kustomize:

configMapGenerator:
  - name: icons files: - eventc-icon.png

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

This allows adding icons to generic events, e.g. add:

  extraVolumeMounts:
    - mountPath: /app/public/icons/eventc-icon.png
      name: icons
      subPath: eventc-icon.png
  extraVolumes:
    - name: icons
      configMap:
        name: icons

to the frontend section (and make a config map with your icon).

I added the icon config map via kustomize:

    configMapGenerator:
      - name: icons
        files:
          - eventc-icon.png
@donbowman donbowman requested a review from talboren as a code owner February 15, 2025 17:32
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren enabled auto-merge (squash) February 24, 2025 08:54
@talboren talboren merged commit 9eaef9a into keephq:main Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants