Include table_name in scopes to allow for JOIN operations
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want to support general composability, wouldn't we want to quote names? For instance: connection.quote_table_name_for_assignment(table_name, column_name) |
|
What is necessary to finish with this issue? |
|
I can apply @kenn 's suggestion, if that is generally agreed upon… |
|
@fjaeger I think that will be enough. Another solution to use arel, like: Arel::Nodes::BitwiseAnd.new(arel_table[attribute], flags.to_i(value)).gt(0) |
|
I would also add a test case with a composed join operation? |
|
I applied a refactoring and added a corresponding test |
|
Looks like some tests are failing? Would you take a look? |
|
@kenn I doubt that the failing tests are due to this PR's changes. It seems there was a recent release of https://github.com/sparklemotion/sqlite3-ruby which is only used for Ruby3 and which fails to load on the test environment you are using here. |
|
Released as v2.0.0 — thank you, @fjaeger ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.