Skip to content

Feature improvements 1#3

Open
denriquezfirestorm wants to merge 4 commits into
kennyjensen:masterfrom
denriquezfirestorm:feature-improvements-1
Open

Feature improvements 1#3
denriquezfirestorm wants to merge 4 commits into
kennyjensen:masterfrom
denriquezfirestorm:feature-improvements-1

Conversation

@denriquezfirestorm

Copy link
Copy Markdown

This pull request encompasses several feature improvements.

@kennyjensen

Copy link
Copy Markdown
Owner

Thank you for all the bug reports, feature requests, and feature implementations! Because of the nature of vibe coding, I think it will be easier to just submit bug reports / feature requests rather than the full implementations. Here are some comments / questions about this PR:

  1. Thanks for finding the viscous issue! Surprisingly few of the .avl files in the runs/ directory were using the CDCL section, so my tests didn't catch this. I've fixed it now, so it automatically turns viscous on when it encounters a CDCL section, similar to AVL. I'd prefer to not expose "Viscous" as an option to keep the interface simpler.

  2. What does localStorage do here? What is the behavior you want that wasn't there?

  3. I don't want to add a docs button to the title bar. I'd definitely consider adding one somewhere else, but I'd prefer it just display the standard avl_doc.txt. Let me know if you're interested in that.

  4. For the afile name, I agree is should just show the tail. For mass file loading, does this change make it more similar to AVL's default behavior (which I'm trying to respect). Does AVL automatically, "apply" the mass file when you load a new one? If so, I'm happy to accept this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants