This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Add fold post-processing bool to SQLAlchemySchemaInfo #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding whether or not post-processing should be applied to
SQLAlchemySchemaInfo
based on @obi1kenobi's comment on #1008.I opted to default to automatic inference of whether or not fold post-processing is required based on
isinstance(dialect, MSDialect)
, which could create a bug if SQLAlchemy adds a MSSQL dialect that does not inherit fromMSDialect
. This can be overruled with the keyword argrequires_fold_postprocessing
in bothmake_sqlalchemy_schema_info
andget_sqlalchemy_schema_info
. I thought inferring would be more user friendly, but could make explicitly settingrequires_fold_postprocessing
required if there's an argument for that approach.