use jQuery css function instead of width #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -549,7 +549,7 @@ | |||
| }; | |||
| _.$slider.html(newSlides); | |||
| _.$slider.children().children().children() | |||
| .width((100 / _.options.slidesPerRow) + "%") | |||
| .css('width', (100 / _.options.slidesPerRow) + "%") | |||
| .css({'display': 'inline-block'}); | |||
There was a problem hiding this comment.
You can actually do
_.$slider.children().children().children()
.css({
'width': (100 / _.options.slidesPerRow) + "%",
'display': 'inline-block'
});There was a problem hiding this comment.
Agreed, forgot the syntax when I first wrote it. Updated.
|
Thanks, @ethanclevenger91, it looks good! |
simeydotme
added a commit
that referenced
this pull request
May 12, 2015
use jQuery css function instead of width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken: http://codepen.io/ethanclevenger91/pen/MwwoqJ
Fixed: http://codepen.io/ethanclevenger91/pen/EjjXdb
Could honestly be a jQuery thing, but in the
buildRowsfunction:.width((100 / _.options.slidesPerRow) + "%")adds padding to the value written.
(100 / _.options.slidesPerRow) + '%'may result in33.33...%, but if you havepadding:5px, you can log right after that line the value and see that it's been set to43.33...%- 10% is added (twice the padding as a percentage). Swapping that line for:.css('width', (100 / _.options.slidesPerRow) + "%")resolves the issue.Didn't see build instruction - let me know if I need to take care of that