-
Notifications
You must be signed in to change notification settings - Fork 247
updated headingStyle for mobile screens in quickStartFilter #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves mobile responsiveness of the "✨ AI Suggested Sample Apps" heading in QuickstartFilter.js by making the heading style dynamically adjust based on screen width. The changes reduce margin and font size on mobile devices (< 480px) for better spacing and readability.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imdeveshshukla can you please share a video it will be easy for us to review, also please fix the lint and DCO issues
78ec824 to
5d2f3b7
Compare
Recording.2025-10-24.004618.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imdeveshshukla can you please fix the copilot suggestions and also please fix the lint issue
|
Hi @Achanandhi-M, I’ve already fixed the Copilot suggestions and addressed the lint issues. Hopefully, everything should be resolved now. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imdeveshshukla, this PR looks like it’s mainly a styling issue, right? Could you please explain why we need to use useEffect for this change?
Also please fix the lint issue
Signed-off-by: Devesh Shukla <[email protected]>
|
@Achanandhi-M I’ve also updated the commit message, so the previous linting error should now be resolved. Please let me know if there’s anything else that needs adjustment. |
@imdeveshshukla A simple media query works fine, and also fix the linter issues |
|
Hey @Achanandhi-M, I’ve updated the PR. |
Vale docs linter is not an actual problem please try to fix the DCO |
Signed-off-by: Devesh Shukla <[email protected]>
I’ve fixed the DCO issue, please check now. |
|
Hey @Achanandhi-M, please let me know if there is anything else I should update or fix in the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imdeveshshukla thanks now the pipelines passed, also i found there are two styles in the h2 in the code one is the class name and the another one is style, is the both are different?
|
@Achanandhi-M Yes, both are different. The class name is used to handle the media queries since we can’t include media queries directly in the inline style attribute in JSX. |
What has changed?
Adjusted the heading style for the “✨ AI Suggested Sample Apps” section in QuickstartFilter.js to improve mobile responsiveness.
The headingStyle object now dynamically adjusts marginLeft and fontSize based on the screen width (using window.innerWidth < 480).
This ensures that the header text is properly spaced and sized on smaller devices without affecting the desktop layout.
This PR Resolves #2987
Type of change
How Has This Been Tested?
Before: Header appeared slightly left-cramped and oversized on mobile.

After: Header spacing and font size adjust automatically for better readability.

Checklist: