Skip to content

refactor: standardize delete endpoint response with ResponseEntity #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mridul-20
Copy link

@mridul-20 mridul-20 commented Jun 18, 2025

Pull Request Template

Description

This PR refactors the delete endpoint in EmployeeController to return a ResponseEntity, ensuring consistency with other endpoints and improving response handling. The change standardizes the response format, making it clearer and more aligned with best practices.

Changes

  • Updated deleteEmployee method to return ResponseEntity<Map<String, Boolean>> instead of just Map<String, Boolean>
  • Added ResponseEntity.ok() wrapper to maintain consistency with other endpoints

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@pratik-mahalle
Copy link

Hey @mridul-20, Thank you for raising the pr. Our team will review the changes soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants