Update react version 18 #347
Open
+17,986
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
solanamr
approved these changes
Jun 28, 2022
narthur
suggested changes
Jul 12, 2022
| }, | ||
| "peerDependencies": { | ||
| "react": "^16.0.0" | ||
| "react": "^18.0.0" |
There was a problem hiding this comment.
Does this have to require 18? Could this be something more like this?:
"react": ">= 16.0.0 < 19"
Or whatever the lowest functioning version is?
I'm asking because I currently have a repository with React 17.0.2, and it would be nice if React 17 was supported.
There was a problem hiding this comment.
I agree, we use react 17 so your suggestion will work for most use cases.
|
Can we get this merged please? |
asheesh-hub
approved these changes
Oct 13, 2022
Maduz0097
approved these changes
Oct 30, 2022
|
When this pr is merged? i want to use this package |
|
is this package ever gonna be updated ? |
|
I'm waiting for this to get merged too 🤞 |
|
You can use my package instead it's currently maintaining and has simillar interface 😃 |
fepimentel
approved these changes
Apr 9, 2023
d4rtnu11
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project to run with React 18