Skip to content

Disable loading functions within deserialization. #21412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

hertschuh
Copy link
Collaborator

Loading files while loading a model is not allowed.

Loading files while loading a model is not allowed.
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (e4bca84) to head (12bbc23).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/saving/serialization_lib.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21412      +/-   ##
==========================================
+ Coverage   82.67%   82.72%   +0.04%     
==========================================
  Files         565      565              
  Lines       55064    55222     +158     
  Branches     8569     8609      +40     
==========================================
+ Hits        45525    45683     +158     
+ Misses       7441     7428      -13     
- Partials     2098     2111      +13     
Flag Coverage Δ
keras 82.53% <50.00%> (+0.05%) ⬆️
keras-jax 63.33% <50.00%> (-0.18%) ⬇️
keras-numpy 58.53% <50.00%> (-0.15%) ⬇️
keras-openvino 33.79% <50.00%> (+0.33%) ⬆️
keras-tensorflow 63.74% <50.00%> (-0.17%) ⬇️
keras-torch 63.37% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 24, 2025
@hertschuh hertschuh merged commit 3d6022a into keras-team:master Jun 24, 2025
9 of 11 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Jun 24, 2025
@hertschuh hertschuh deleted the load_in_load branch June 24, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants