Skip to content

Comments

feat: add Pool column to browsers list#117

Open
masnwilliams wants to merge 1 commit intomainfrom
mason/pool-column-browsers-list
Open

feat: add Pool column to browsers list#117
masnwilliams wants to merge 1 commit intomainfrom
mason/pool-column-browsers-list

Conversation

@masnwilliams
Copy link
Contributor

@masnwilliams masnwilliams commented Feb 19, 2026

Summary

  • Add a "Pool" column to kernel browsers list table output showing the pool ID for browsers acquired from a pool (or "-" for regular browsers)
  • Uses SDK ExtraFields to extract pool_id until the Go SDK is regenerated with the new field

Depends on kernel/kernel#1286 for the API to return pool_id.

Test plan

  • kernel browsers list with pooled browsers shows pool ID in Pool column
  • kernel browsers list with regular browsers shows "-" in Pool column
  • kernel browsers list --output json includes pool_id for pooled browsers

Made with Cursor


Note

Medium Risk
UI output change is low impact, but the go.mod replace redirects a core SDK dependency to a forked commit, which can affect API compatibility and downstream builds.

Overview
Adds a new "Pool" column to kernel browsers list table output, populated from browser.PoolID and shown as - when absent.

Pins the Kernel Go SDK to a fork via a go.mod replace (with corresponding go.sum updates) to pick up the PoolID field before the upstream SDK is regenerated.

Written by Cursor Bugbot for commit 34d1e41. This will update automatically on new commits. Configure here.

@masnwilliams masnwilliams requested a review from Sayan- February 19, 2026 23:04
Show pool_id in the browser list table for browsers acquired from a
pool. Extracts pool_id from SDK ExtraFields until the SDK is regenerated
with the new field.

Related: kernel/kernel#1286
Co-authored-by: Cursor <[email protected]>
@masnwilliams masnwilliams force-pushed the mason/pool-column-browsers-list branch from f866b7c to 34d1e41 Compare February 19, 2026 23:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/kernel/kernel-go-sdk => github.com/stainless-sdks/kernel-go v0.0.0-20260219230517-75bf6df66f0b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development SDK replace directive committed to production

High Severity

The replace directive in go.mod points to a pre-release SDK from the private stainless-sdks/kernel-go repository. The project's own DEVELOPMENT.md documents go-mod-replace-kernel.sh as a development-time workflow for testing against unreleased API changes. This replace directive is a temporary development aid that pins the build to an unstable, pre-release commit and isn't suitable for merging to main or releasing.

Fix in Cursor Fix in Web

@kernel-internal
Copy link
Contributor

🔧 CI Fix Available

I've pushed a fix for the CI failure. The issue was that the replace directive in go.mod pointed to a private repository (github.com/stainless-sdks/kernel-go) that CI cannot access.

The fix uses the SDK's ExtraFields mechanism to extract pool_id from the API response, which works with the public SDK (github.com/kernel/[email protected]).

👉 Click here to create a PR with the fix

Copy link
Contributor

@Sayan- Sayan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm - one suggestion. once we publish the new sdk please re-request review and we'll 🚢

Comment on lines +301 to +304
poolID := "-"
if browser.PoolID != "" {
poolID = browser.PoolID
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should default to pool name over id if available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants