fix: wire DockerSocket config into build manager#121
Merged
rgarcia merged 1 commit intocodex/mac-standby-supportfrom Mar 3, 2026
Merged
fix: wire DockerSocket config into build manager#121rgarcia merged 1 commit intocodex/mac-standby-supportfrom
rgarcia merged 1 commit intocodex/mac-standby-supportfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Agent signal forwarder handles only one signal
- Changed the guest-agent signal forwarder to continuously range over the signal channel so all shutdown signals are forwarded instead of only the first.
Or push these changes by commenting:
@cursor push d964c3fb27
Preview (d964c3fb27)
diff --git a/lib/system/init/mode_exec.go b/lib/system/init/mode_exec.go
--- a/lib/system/init/mode_exec.go
+++ b/lib/system/init/mode_exec.go
@@ -152,8 +152,9 @@
agentSigCh := make(chan os.Signal, 1)
signal.Notify(agentSigCh, syscall.SIGTERM, syscall.SIGHUP, syscall.SIGQUIT, syscall.SIGINT)
go func() {
- sig := <-agentSigCh
- agentCmd.Process.Signal(sig)
+ for sig := range agentSigCh {
+ agentCmd.Process.Signal(sig)
+ }
}()
agentCmd.Wait()
signal.Stop(agentSigCh)cfg.Build.DockerSocket was parsed from config.yaml but never passed to builds.Config, so the docker_socket setting was silently ignored and the build manager always fell back to /var/run/docker.sock.
5ef5f14 to
848d7e4
Compare
sjmiller609
approved these changes
Mar 3, 2026
sjmiller609
added a commit
that referenced
this pull request
Mar 3, 2026
* Describe implementing vz standby * Fix VZ standby review issues * Increase CI test timeout and fix standby test nil deref * Add VZ fork preparation and running-fork integration test * Generalize vsock socket naming and add VZ standby fork integration * Update readme * Delete redundant test * fix: wire DockerSocket config and keep VM alive after entrypoint exits Two fixes for macOS development: 1. Wire cfg.Build.DockerSocket into builds.Config so the config file value (e.g. Colima socket path) is actually used instead of always falling back to /var/run/docker.sock. 2. Restore pre-PR#99 behavior of keeping the VM alive after the entrypoint exits by waiting on the guest-agent. PR#99 changed init to immediately power off the VM when the entrypoint exits, which breaks images like alpine:latest whose CMD is /bin/sh — the shell gets no stdin and exits instantly, killing the VM before anyone can `hm exec` into it. The guest-agent keeps the VM alive and accessible until an explicit stop/delete. * Revert "fix: wire DockerSocket config and keep VM alive after entrypoint exits" This reverts commit 37272ca. * fix: wire DockerSocket config into build manager (#121) cfg.Build.DockerSocket was parsed from config.yaml but never passed to builds.Config, so the docker_socket setting was silently ignored and the build manager always fell back to /var/run/docker.sock. --------- Co-authored-by: Rafael Garcia <raf@kernel.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
cfg.Build.DockerSocketwas defined in the app config struct and parsed fromconfig.yaml, but never passed through tobuilds.Configinlib/providers/providers.go. This meant thedocker_socketvalue (e.g. Colima's~/.colima/default/docker.sock) was silently ignored and the build manager always fell back to the hardcoded/var/run/docker.sock, breakingmake dev-darwinon machines using Colima or other non-default Docker socket paths.Change
One-line fix in
lib/providers/providers.go— addsDockerSocket: cfg.Build.DockerSocketto thebuilds.Configinitialization.Made with Cursor
Note
Low Risk
Low risk config plumbing change: it only adds a missing field mapping so the build manager can use a non-default Docker socket path; no behavioral changes elsewhere unless
Build.DockerSocketis set.Overview
Wires
cfg.Build.DockerSocketthroughProvideBuildManagerintobuilds.Config, so the build system can use a configured Docker socket path instead of implicitly relying on the default socket.Written by Cursor Bugbot for commit 848d7e4. This will update automatically on new commits. Configure here.