Volume multi-attach

[sjmiller609]

No description provided.

[github-actions]

✱ Stainless preview builds

This PR will update the hypeman SDKs with the following commit message.

feat: Volume readonly multi-attach

⚠️ hypeman-go studio · code

There was a regression in your SDK.
generate ✅ → lint ❗ → test ❗

go get github.com/stainless-sdks/hypeman-go@ad4dbc545489514d2d18319495165601c894bb0c

✅ hypeman-cli studio · code

Your SDK built successfully.
generate ✅ → lint ✅ → test ⏳

---

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
Last updated: 2025-12-02 22:23:36 UTC

[mesa-dot-dev]

Mesa Description

TL;DR

Implemented volume multi-attach functionality, allowing a single volume to be attached to multiple instances simultaneously for read-only access, while maintaining single read-write attachment capability.

Why we made these changes

To enhance flexibility and resource sharing by removing the previous 'one instance at a time' limitation for volumes, enabling read-only sharing across multiple instances.

What changed?

• Volume Manager Refactoring: The Volume struct and volume manager (lib/volumes/manager.go, lib/volumes/types.go, lib/volumes/storage.go) were refactored to transition from a single AttachedTo field to an Attachments slice, supporting multiple attachments per volume.
• Multi-Attach Rules Enforcement: New rules were introduced and enforced, allowing either a single read-write attachment or multiple read-only attachments.
• API and Instance Logic Updates:
  • volumeToOAPI function (cmd/api/api/volumes.go) updated to map Attachments slice to oapi.VolumeAttachmentInfo objects, detailing InstanceID, MountPath, and Readonly.
  • Volume attachment/detachment logic in lib/instances/create.go and lib/instances/delete.go refined to handle multi-attach, with DetachVolume now including the instance ID.
• Init Script Modification: Added noload option to mount commands for read-only mounts in lib/system/init_script.go to skip journal recovery.
• Documentation and OpenAPI Updates:
  • lib/volumes/README.md updated to detail the "Multi-Attach (Read-Only Sharing)" feature, new rules, and revised volume constraints (preventing deletion while attached).
  • openapi.yaml and lib/oapi/oapi.go were updated/regenerated to reflect API specification changes.

Validation

• New integration test TestVolumeMultiAttachReadOnly (lib/instances/volumes_test.go) validates the ability to attach a volume read-write, then detach, and finally attach it read-only to multiple instances.
• Comprehensive unit tests in lib/volumes/manager_test.go validate the Volume Manager's attachment and detachment logic across various single and multi-attach scenarios, including read-write/read-only combinations, duplicate instance handling, and preventing deletion while attached.
• TestCreateAndDeleteInstance (lib/instances/manager_test.go) updated to check the new Attachments slice for volume status.

^{Description generated by Mesa. Update settings}

[mesa-dot-dev]

Performed full review of 32fc530...439eb66

Analysis

1. API Breaking Change: The transition from single-attachment model to multi-attachment model represents a breaking API change for clients expecting the old attachment format. This needs to be clearly communicated to API consumers.

2. Inefficient Validation Logic: The AttachVolume method performs multiple separate iterations over the meta.Attachments array for different validation checks, which could be combined into a single loop for better performance.

3. Error Handling in Cleanup Scenarios: The DetachVolume function returns an error when a volume isn't attached to a specified instance, but this isn't properly handled in cleanup scenarios where the error is logged but ignored.

4. Minor Optimization Opportunities: The newAttachments slice is preallocated with len(meta.Attachments) when it should use len(meta.Attachments)-1 since one element is being removed.

Tip

Help

Slash Commands:

• /review - Request a full code review
• /review latest - Review only changes since the last review
• /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
• /help - Get help with Mesa commands and configuration options

^{13 files reviewed | 0 comments | Edit Agent Settings • Read Docs}

[rgarcia]

Added some review comments - mostly questions about cleanup paths and test coverage. The multi-attach and overlay implementation looks solid overall.