Conversation
There was a problem hiding this comment.
Performed full review of 1f705b9...ea67179
Analysis
-
The PR centralizes escaping of special characters for JSON keys through a new
EscapeSJSONKeyfunction, but it may not be immediately obvious to developers that this function should be used for all JSON key operations to maintain consistency. -
While the PR improves character coverage by handling additional special characters (
\\,|,#,@,?), it's unclear if a comprehensive analysis was done to ensure all possible problematic characters are now properly escaped. -
The fix is applied to three specific areas (encoder, union, parameter marshaling), but there could be other places in the codebase that manipulate JSON keys that weren't identified and may still contain the bug.
-
The PR doesn't appear to include additional tests specifically targeting edge cases with the newly handled special characters, which could lead to regressions in the future.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
ea67179 to
a98acc3
Compare
a98acc3 to
cf12325
Compare
cf12325 to
04cd6ea
Compare
Release version edited manuallyThe Pull Request version has been manually set to If you instead want to use the version number |
04cd6ea to
5caef65
Compare
|
🤖 Release is at https://github.com/onkernel/kernel-go-sdk/releases/tag/v0.11.5 🌻 |
Automated Release PR
0.11.5 (2025-09-29)
Full Changelog: v0.11.4...v0.11.5
Features
Bug Fixes
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Description generated by Mesa. Update settings