[chromium-headless]: fix headless browsers start with no pages#104
Merged
archandatta merged 2 commits intomainfrom Dec 12, 2025
Merged
[chromium-headless]: fix headless browsers start with no pages#104archandatta merged 2 commits intomainfrom
archandatta merged 2 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
rgarcia
approved these changes
Dec 12, 2025
archandatta
force-pushed
the
archand/kernel-638/fix-breaking-target
branch
from
de6a647 to
d5c4556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address a bug with creating headless browsers with
--no-startup-windowflag causing breaking Target.createTarget CDP calls.Ticket
Testing
TestCDPTargetCreationtest. Test should pass withinitial_page_count=1--no-startup-windowinwrapper.sh, rebuild the docker image inimages/chromium-headlessand rerun theTestCDPTargetCreationtest, the test should failNote
Removes the --no-startup-window flag so headless Chromium starts with a page, and adds an e2e test that verifies CDP target creation.
--no-startup-windowfrom defaultCHROMIUM_FLAGSinimages/chromium-headless/image/wrapper.shto ensure an initial page target exists.TestCDPTargetCreationinserver/e2e/e2e_chromium_test.goto assert at least onepagetarget via CDP.listCDPTargetshelper to queryhttp://localhost:9223/json/list.Written by Cursor Bugbot for commit d5c4556. This will update automatically on new commits. Configure here.