Skip to content

[kernel:781] update loading logo animation to pulse #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archandatta merged 2 commits into from
Jan 14, 2026
Merged

[kernel:781] update loading logo animation to pulse #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e39e95e
fix: update loading logo animation to pluse
archandatta Jan 14, 2026
8d07457
update pulse animation
archandatta Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions images/chromium-headful/client/src/components/about.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@
align-items: center;

.window {
max-width: 70vw;
Copy link

@cursor cursor bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Window styling accidentally removed breaking visual appearance

High Severity

The .window class lost essential styling properties (background, border-radius, max-width/width, max-height, overflow, padding) that were accidentally deleted. This PR was only meant to update the animation to pulse, but these unrelated style removals will cause the window to appear transparent/unstyled with no size constraints, breaking the UI completely.

Additional Locations (1)

Fix in Cursor Fix in Web

background: $background-secondary;
border-radius: 5px;
max-height: 70vh;
overflow-y: auto;
overflow-x: hidden;

&::-webkit-scrollbar {
width: 8px;
}
Expand Down Expand Up @@ -91,13 +84,7 @@
.kernel-logo {
width: 100%;
height: 100%;
animation: kernel-logo-spin 1s linear infinite;
}

@media (prefers-reduced-motion: reduce) {
.kernel-logo {
animation: none;
}
animation: kernel-logo-pulse 1.5s ease-in-out infinite;
Copy link

@cursor cursor bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed accessibility check for reduced motion preference

Medium Severity

The @media (prefers-reduced-motion: reduce) blocks that previously disabled animation for users who have configured their system to prefer reduced motion were removed. This was an existing accessibility feature, not defensive coding. Users with vestibular disorders who explicitly requested no animations will now see the continuous pulse animation, which can cause physical discomfort.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Contributor

@tembo tembo bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this animates continuously, I’d keep the prefers-reduced-motion: reduce override that was removed (or at least reduce/disable the pulse) so we don’t force motion for users who opt out. Same applies in connect.vue.

}
}
}
Expand All @@ -108,12 +95,15 @@
}
}

@keyframes kernel-logo-spin {
from {
transform: rotate(0deg);
@keyframes kernel-logo-pulse {
0%,
100% {
transform: scale(0.85);
opacity: 0.7;
}
to {
transform: rotate(360deg);
50% {
transform: scale(1);
opacity: 1;
}
}
</style>
Expand Down
26 changes: 9 additions & 17 deletions images/chromium-headful/client/src/components/connect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
align-items: center;

.window {
width: 300px;
background: $background-secondary;
border-radius: 5px;
padding: 10px;

.logo {
width: 100%;
display: flex;
Expand Down Expand Up @@ -111,24 +106,21 @@
.kernel-logo {
width: 100%;
height: 100%;
animation: kernel-logo-spin 1s linear infinite;
}

@media (prefers-reduced-motion: reduce) {
.kernel-logo {
animation: none;
}
animation: kernel-logo-pulse 1.5s ease-in-out infinite;
}
}
}
}

@keyframes kernel-logo-spin {
from {
transform: rotate(0deg);
@keyframes kernel-logo-pulse {
Copy link
Contributor

@tembo tembo bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kernel-logo-pulse is defined in both about.vue and connect.vue now. If this is intended to stay identical, might be worth hoisting to a shared stylesheet/SCSS partial so tweaks (duration/scale/reduced-motion) don’t drift between components.

0%,
100% {
transform: scale(0.85);
opacity: 0.7;
}
to {
transform: rotate(360deg);
50% {
transform: scale(1);
opacity: 1;
}
}
</style>
Expand Down
Loading