Fix docker build failure when buildkit container is absent#22
Merged
Sayan- merged 3 commits intokernel:mainfrom Jul 8, 2025
Merged
Fix docker build failure when buildkit container is absent#22Sayan- merged 3 commits intokernel:mainfrom
Sayan- merged 3 commits intokernel:mainfrom
Conversation
matthewjmarangoni
force-pushed
the
fix-docker-build
branch
from
52e865c to
bb04481
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matthewjmarangoni
force-pushed
the
fix-docker-build
branch
from
bb04481 to
19340bd
Compare
Sayan-
requested changes
Jul 8, 2025
Contributor
Sayan-
left a comment
Sayan-
left a comment
There was a problem hiding this comment.
Hey @matthewjmarangoni - thanks for flagging! I did some quick local testing and with your proposed changes the start-buildkit.sh would bail out any time the container exists but is "stopped". Instead I propose folding the test's into if's
Contributor
Author
|
Thanks for finding that and the updates @Sayan-! The suggestions were integrated and testing worked. |
Co-authored-by: Sayan <[email protected]>
…nditional Co-authored-by: Sayan <[email protected]>
matthewjmarangoni
force-pushed
the
fix-docker-build
branch
from
23db82f to
95ece89
Compare
Sayan-
approved these changes
Jul 8, 2025
Contributor
Sayan-
left a comment
Sayan-
left a comment
There was a problem hiding this comment.
Appreciate your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Building the docker container fails when the buildkit container does not already exist.
The failure is from a sourced script testing for container presence. The script exits when the test fails while having inherited the
-ebash option.The sourced presence test is modified. Additionally a typo is corrected, an EOF newline is added, and the sourcing script has bash tracing output disabled.