Keepalive fix cleanup [kernel-images]#49
Conversation
Mesa DescriptionTL;DRMigrated WebSocket keepalive from client-initiated heartbeats to server-sent system pongs, ensuring more stable connections, and removed related temporary chat fixes. Why we made these changesTo stabilize WebSocket connections by adopting a robust server-side What changed?
|
There was a problem hiding this comment.
What Changed
This pull request refactors the WebSocket keepalive mechanism by upgrading the base Docker image to neko/base:3.0.6-v1.0.1. This new image provides a native system/pong keepalive event, allowing for the removal of a temporary workaround that used the chat system to maintain the connection. Accordingly, the client-side code in images/chromium-headful/client/ has been updated to remove the old heartbeat logic and the chat feature has been disabled in neko.yaml.
Risks / Concerns
This is a great cleanup PR that replaces a temporary workaround with a more robust, standardized solution. The changes are straightforward and well-contained. One minor point of clarification could be the new system/pong handler in images/chromium-headful/client/src/neko/index.ts, which is currently commented out. Assuming this is intentional or placeholder code, there are no significant risks.
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
|
thanks as always @raiden-staging ! |
system/pongclient/heartbeat→system/pongreply with 10s interval works ✅Next Steps :
onkernel/nekoKeepalive fix cleanup [neko])v3.0.6-v1.0.1onkernel/kernel-imagesKeepalive fix cleanup [kernel-images]). Notes :Dockerfilealready set to ghcr.io/onkernel/neko/base:3.0.6-v1.0.1onkernel/neko:v3.0.6-v1.0.1tag release and build completion, would work without needing changes in this PR[ @Sayan- @rgarcia ]