Change default viewport to 1920x1080@25#86
Merged
hiroTamada merged 2 commits intomainfrom Oct 28, 2025
Merged
Conversation
Mesa DescriptionChecklist
This PR changes the default viewport to 1920x1080@25.
Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Performed full review of 6d144ca...593f8e5
Analysis
- Inconsistent refresh rate change from 60Hz to 25Hz across configuration files, which lacks clear justification and may negatively impact user experience
- The significant resolution increase (1024x768 to 1920x1080) may have performance implications on resource-constrained systems that are not addressed
- While environment variables are used to centralize resolution settings, there's no evidence of backward compatibility considerations for systems already deployed with the previous configuration
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
6 files reviewed | 0 comments | Edit Agent Settings
rgarcia
approved these changes
Oct 28, 2025
Sayan-
reviewed
Oct 28, 2025
Contributor
Author
we dont. But technically, you can override through the env I think. So I just kept it as an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Note
Set the default viewport to 1920x1080 (25Hz where applicable) across headful/headless images, configs, and run scripts.
images/chromium-headful/Dockerfile: SetENV HEIGHT=1080andENV WIDTH=1920.images/chromium-headful/neko.yaml: Update desktopscreento"1920x1080@25".images/chromium-headful/run-docker.shandrun-unikernel.sh: PassHEIGHT=1080andWIDTH=1920to the container/instance.images/chromium-headless/image/start-xvfb.sh: DefaultWIDTH=1920,HEIGHT=1080.images/chromium-headless/image/wrapper.sh: Export defaultsHEIGHT=1080,WIDTH=1920.Written by Cursor Bugbot for commit 593f8e5. This will update automatically on new commits. Configure here.