-
Notifications
You must be signed in to change notification settings - Fork 42
toggle cursor visibility #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6101c4
squash commits
mateoCuervo 7bb078d
dynamic display
mateoCuervo 5f0adbc
docs: update images/chromium-headful/README.md
mateoCuervo eaffbca
docs: update images/chromium-headful/README.md
mateoCuervo 533f912
docs: update images/chromium-headful/README.md
mateoCuervo 51ef3a0
chore: delete images/chromium-headful/README.md
mateoCuervo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## How to test kernel-images changes locally with docker | ||
|
|
||
| - Make relevant changes to kernel-images example adding a new endpoint at `kernel-images/server/cmd/api/api/computer.go`, example I added `SetCursor()` endpoint. | ||
| - Run openApi to generate the boilerplate for the new endpoints with make oapi-generate | ||
| - Check changes at `kernel-images/server/lib/oapi/oapi.go` | ||
| - `cd kernel-images/images/chromium-headful` | ||
| - Build and run the docker image with `./build-docker.sh && ENABLE_WEBRTC=true ./run-docker.sh` | ||
| - Open http://localhost:8080/ in your browser | ||
| - Now new endpoint should be available for tests example curl command: | ||
| ```sh | ||
| curl -X POST localhost:444/computer/cursor \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{"hidden": true}' | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Display Handling Causes Unclutter Failures
The
SetCursorfunction hardcodesDISPLAY=:1forunclutter, which is inconsistent with other display resolution methods and may cause cursor hiding to fail. Theunclutterprocess is also started without being waited on, potentially creating zombie processes. Additionally,pkill's error handling broadly interpretsexit code 1as 'no processes found,' which could mask other failures.