-
Notifications
You must be signed in to change notification settings - Fork 20
feat(notifications): add hardware_summary action #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notifications): add hardware_summary action #1610
Conversation
629b5a1 to
269cd86
Compare
|
Hello and thanks for the contribution! We will check this PR as soon as we can. For now, please check the lint rules, you can use the linter locally to check for required changes. Commit and PR description looks good! I glanced over the changes and they look well written, I would just make a nitpick for leaving a |
|
Hello, Thanks for this. Can you also attach and example output from running this command. I want to review how the report output is coming out. |
2f1cc1a to
603424a
Compare
Thanks for your feedback! Here’s an example report output, showing only a limited number of items for clarity. |
|
It is looking great. Thanks for sharing. I am fine with the output being generated and with the yaml config file for hardware. I'll let the Dashboard team review it in detail and comment on the implementation. |
MarceloRobert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the notifications.md document with this new command too?
backend/kernelCI_app/management/commands/templates/hardware_report.txt.j2
Show resolved
Hide resolved
603424a to
5d7b78a
Compare
MarceloRobert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to have automatic reports, you have to add a cron job in settings.py like the other ones set up there. Also please fix the CI issues, otherwise it looks good now
Add new hardware_summary action in the notifications management command. This action generates hardware reports based on the subscription file. Signed-off-by: Yushan Li <[email protected]>
5d7b78a to
e37285a
Compare
Thanks, added a cron job in settings.py to trigger the hardware report every Monday, and also fixed the CI issues. |
MarceloRobert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
Description
Add a new hardware_summary action to the notifications management command.
This action generates hardware reports based on the hardware subscription files.
Changes
hardware_summaryaction to the notifications command with CLI argument.How to Test
Run the following command to generate the hardware summary report:
Related Issue
Closes #1081