scheduler: implement /health endpoint for k8s and docker #1253
+92
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sometimes process might get stuck, and this compromise whole idea of scheduler, as events will get lost and etc. We can implement http server thread that will watch for variable that is updated every "loop". If variable not updated anymore, loop is not working anymore. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
receive-event-nonblock
branch
from
a48ba38 to
2a0797a
Compare
Signed-off-by: Denys Fedoryshchenko <[email protected]>
Signed-off-by: Denys Fedoryshchenko <[email protected]>
pawiecz
approved these changes
Jul 15, 2025
| super().__init__(server_address, RequestHandlerClass) | ||
| self.last_heartbeat = last_heartbeat | ||
|
|
||
| server = CustomHTTPServer(('0.0.0.0', 8080), HealthHandler, last_heartbeat) |
There was a problem hiding this comment.
I know listen address was hardcoded to get the probe running quickly (same goes to FAILURE_TIMEOUT).
I'm still pointing it out to assure you I do read your patches before LGTMing them ;)
| @@ -68,22 +92,6 @@ spec: | |||
| - name: tmpsecrets | |||
| mountPath: /home/kernelci/.azure | |||
| subPath: k8s-credentials/.azure | |||
| initContainers: | |||
There was a problem hiding this comment.
Please correct me if I'm wrong: this change is just a cleanup to group both initContainers together, not a functional one?
There was a problem hiding this comment.
Yes, i just spotted mistake when i was editing file. Not best approach to mix in PR, but at least did as separate commit. I was afraid yaml failure might lead to other failures, e.g. to read health section.
Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
receive-event-nonblock
branch
from
8b58976 to
eb0067f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes process might get stuck, and this compromise whole idea of scheduler, as events will get lost and etc.
We can implement http server thread that will watch for variable that is updated every "loop". If variable not updated anymore, loop is not working anymore.
Depends-on: kernelci/kernelci-core#2923