src/timeout: fix logic marking nodes as "incomplete" #1254
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not mark timed-out node as "incomplete" if the result is set to "fail" or "skip". Fixes: fe42dd5 ("src: timeout: make state transitions more predictable") Signed-off-by: Jeny Sadadia <[email protected]>
|
I was investigating baseline jobs with infra issue and came to a scenario where its Job node: https://api.kernelci.org/viewer?node_id=686dabcc34612746bbb7c727 Here are the logs stating I fixed this in the timeout service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not mark timed-out node as "incomplete" if the result is set to "fail" or "skip".
Fixes: fe42dd5 ("src: timeout: make state transitions more predictable")