Add date formatting (optional) #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed on the scenario tests...these seem broken on master too. Any idea what is the problem there? |
|
Looks like maybe the API key on the tests is invalid so the integration tests are failing |
kevbite
approved these changes
Nov 28, 2024
|
Happy to accept this PR. |
|
Hi Kev, Do you know when will the built version get pushed to nuget? Cheers, Rob |
|
@shandybob76 latest version is up on NuGet - https://www.nuget.org/packages/CompaniesHouse/8.0.35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the GetDescription method, some values from Companies House are dates.
I've extended the GetDescription to pass in a date format.
When processing the value we check whether we have a date format, and whether the value is a date from Companies house formatted as yyyy-MM-dd. If it is, parse the date, then apply the passed in format.
Unit tests added.