Skip to content

Commit

Permalink
controller: Upd. remaining refs to generic vif
Browse files Browse the repository at this point in the history
In 97ded78 we renamed
GenericPodVIFDriver to the more accurate NeutronPodVIFDriver.
Unfortunately we missed a few places. This patch solves that.

Change-Id: I441e7236f9e2bb1f64ad5ae5bcc43218adf5abb3
Signed-off-by: Antoni Segura Puimedon <[email protected]>
  • Loading branch information
celebdor committed Jun 7, 2017
1 parent 97ded78 commit 87039c6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions doc/source/devref/kuryr_kubernetes_design.rst
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,13 @@ drivers. There are drivers that handle the Pod based on the project, subnet
and security groups specified via configuration settings during cluster
deployment phase.

GenericPodVifDriver
NeutronPodVifDriver
~~~~~~~~~~~~~~~~~~~
PodVifDriver subclass should implement request_vif, release_vif and
activate_vif methods. In case request_vif returns Vif object in down state,
Controller will invoke activate_vif. Vif ‘active’ state is required by the
CNI driver to complete pod handling.
The GenericPodVifDriver is the default driver that creates neutron port upon
The NeutronPodVifDriver is the default driver that creates neutron port upon
Pod addition and deletes port upon Pod removal.

CNI Driver
Expand Down
6 changes: 3 additions & 3 deletions doc/source/devref/port_manager.rst
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ corresponding pool is empty, a ResourceNotReady exception will be triggered and
the pool will be repopulated.

In addition to the handler modification and the new pool drivers there are
changes related to the VIF drivers. The VIF drivers (generic and nested) will
be extended to support bulk ports creation of Neutron ports and similarly for
the VIF objects requests.
changes related to the VIF drivers. The VIF drivers (neutron-vif and nested)
will be extended to support bulk ports creation of Neutron ports and similarly
for the VIF objects requests.

Future enhancement
''''''''''''''''''
Expand Down
2 changes: 1 addition & 1 deletion kuryr_kubernetes/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
default='default'),
cfg.StrOpt('pod_vif_driver',
help=_("The driver that provides VIFs for Kubernetes Pods."),
default='generic'),
default='neutron-vif'),
cfg.StrOpt('endpoints_lbaas_driver',
help=_("The driver that provides LoadBalancers for Kubernetes "
"Endpoints"),
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ kuryr_kubernetes.controller.drivers.service_security_groups =
default = kuryr_kubernetes.controller.drivers.default_security_groups:DefaultServiceSecurityGroupsDriver

kuryr_kubernetes.controller.drivers.pod_vif =
generic = kuryr_kubernetes.controller.drivers.generic_vif:GenericPodVIFDriver
neutron-vif = kuryr_kubernetes.controller.drivers.neutron_vif:NeutronPodVIFDriver
nested-vlan = kuryr_kubernetes.controller.drivers.nested_vlan_vif:NestedVlanPodVIFDriver

kuryr_kubernetes.controller.drivers.endpoints_lbaas =
Expand Down

0 comments on commit 87039c6

Please sign in to comment.