*: Enable the misspell linter #10680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]>
timflannagan
changed the title
timflannagan
commented
Feb 21, 2025
| @@ -42,7 +42,7 @@ func NewPerClientEnvoyEndpoints( | |||
| glooEndpoints krt.Collection[ir.EndpointsForUpstream], | |||
| translateEndpoints func(kctx krt.HandlerContext, ucc ir.UniqlyConnectedClient, ep ir.EndpointsForUpstream) (*envoy_config_endpoint_v3.ClusterLoadAssignment, uint64), | |||
| ) PerClientEnvoyEndpoints { | |||
| clas := krt.NewManyCollection(glooEndpoints, func(kctx krt.HandlerContext, ep ir.EndpointsForUpstream) []UccWithEndpoints { | |||
There was a problem hiding this comment.
I could add this variable to the allowlist since the linter was complaining it was a misspell of "class" but I decided to rename it.
|
Linter documentation: https://golangci-lint.run/usage/linters/#misspell. |
jenshu
approved these changes
Feb 21, 2025
|
I think its almost inevitable that we hit something that is technically a misspelling but is based on a tech or real reference. Would you mind adding an example ignored word such as via the ignore setup seen here golangci/golangci-lint@353cd2c It can even be a silly non-sense word but serves as a plcaholder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick PR that enables a linter that catches spelling mistakes. Follow-up to #10650 and related to #10496.
Checklist: