Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in spec notes rendering#1232

Open
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/xss-fix-spec-notes-8102138957986238944
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in spec notes rendering#1232
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/xss-fix-spec-notes-8102138957986238944

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH

πŸ’‘ Vulnerability: Untrusted spec notes were rendered via marked.parse() and appended directly to innerHTML in site/app.js without any sanitization.

🎯 Impact: If a user loads a workspace containing malicious .fd spec notes, arbitrary JavaScript could be executed in the user's browser (XSS).

πŸ”§ Fix: Added DOMPurify.sanitize() conditional logic to sanitize the output from marked.parse before concatenating it to the HTML string. We also kept the ADD_ATTR configuration so functional attributes aren't stripped.

βœ… Verification:

  • Validated via node --check site/app.js
  • Inspected the fix to ensure the DOMPurify optional logic mirrors existing safe usages in site/ai-chat.js.

PR created automatically by Jules for task 8102138957986238944 started by @khangnghiem

Sanitize marked.parse HTML output with DOMPurify in site/app.js before injecting it into innerHTML.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant