π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in spec notes rendering#1232
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in spec notes rendering#1232khangnghiem wants to merge 1 commit into
Conversation
Sanitize marked.parse HTML output with DOMPurify in site/app.js before injecting it into innerHTML. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: Untrusted spec notes were rendered via
marked.parse()and appended directly toinnerHTMLinsite/app.jswithout any sanitization.π― Impact: If a user loads a workspace containing malicious
.fdspec notes, arbitrary JavaScript could be executed in the user's browser (XSS).π§ Fix: Added
DOMPurify.sanitize()conditional logic to sanitize the output frommarked.parsebefore concatenating it to the HTML string. We also kept theADD_ATTRconfiguration so functional attributes aren't stripped.β Verification:
node --check site/app.jsDOMPurifyoptional logic mirrors existing safe usages insite/ai-chat.js.PR created automatically by Jules for task 8102138957986238944 started by @khangnghiem