🛡️ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1234
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1234khangnghiem wants to merge 1 commit into
Conversation
When marked.parse parses markdown, the resulting HTML can contain malicious script tags and attributes if the raw note is compromised. This updates app.js to sanitize the output via DOMPurify before appending to the DOM. It correctly falls back to escaping raw text securely if DOMPurify isn't available. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Untrusted user input via markdown notes could be rendered into HTML and appended to the DOM via
innerHTMLwithout sanitization whenmarked.parseis available.🎯 Impact: This allows malicious scripts embedded within the raw note content to be executed when the markdown is rendered, enabling Cross-Site Scripting (XSS).
🔧 Fix: Sanitizes the resulting HTML output of
marked.parsewithwindow.DOMPurify.sanitizebefore inserting it. If DOMPurify is unavailable, the fix degrades gracefully and securely by returning a raw text-escaped<pre>block.✅ Verification: Ensure that adding an HTML script payload in a note node renders safely. Evaluated via code review and unit tests locally.
PR created automatically by Jules for task 4767566501783674775 started by @khangnghiem