Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS Attribute Breakout in escHtml#1236

Open
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/xss-attribute-breakout-5171890118654489
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS Attribute Breakout in escHtml#1236
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/xss-attribute-breakout-5171890118654489

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The custom HTML escaping function escHtml in site/layers.js incorrectly omitted the single quote replacement entirely. This allowed for attribute breakout vulnerabilities when inserting untrusted input into single-quoted HTML attributes.
🎯 Impact: An attacker could potentially inject malicious scripts if untrusted data is passed to escHtml and then inserted into a single-quoted HTML attribute, leading to Cross-Site Scripting (XSS).
πŸ”§ Fix: Updated escHtml to use .replace(/'/g, ''') and cast the input to String(s) to ensure complete escaping of single quotes and prevent crashes on null/undefined values.
βœ… Verification: Ran node --check site/layers.js to validate syntax and cd fd-vscode && pnpm test to run the test suite. All tests passed.


PR created automatically by Jules for task 5171890118654489 started by @khangnghiem

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant