π‘οΈ Sentinel: [HIGH] Fix XSS Attribute Breakout in escHtml#1236
π‘οΈ Sentinel: [HIGH] Fix XSS Attribute Breakout in escHtml#1236khangnghiem wants to merge 1 commit into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: The custom HTML escaping function
escHtmlinsite/layers.jsincorrectly omitted the single quote replacement entirely. This allowed for attribute breakout vulnerabilities when inserting untrusted input into single-quoted HTML attributes.π― Impact: An attacker could potentially inject malicious scripts if untrusted data is passed to
escHtmland then inserted into a single-quoted HTML attribute, leading to Cross-Site Scripting (XSS).π§ Fix: Updated
escHtmlto use.replace(/'/g, ''')and cast the input toString(s)to ensure complete escaping of single quotes and prevent crashes on null/undefined values.β Verification: Ran
node --check site/layers.jsto validate syntax andcd fd-vscode && pnpm testto run the test suite. All tests passed.PR created automatically by Jules for task 5171890118654489 started by @khangnghiem