Skip to content

test: Add WASM text metric update coverage (R3.46)#1238

Open
khangnghiem wants to merge 1 commit into
mainfrom
test/r3-46-update-text-metrics-tests-8318446655495389111
Open

test: Add WASM text metric update coverage (R3.46)#1238
khangnghiem wants to merge 1 commit into
mainfrom
test/r3-46-update-text-metrics-tests-8318446655495389111

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

This PR adds unit test coverage for the WASM-side update_text_metrics API, fulfilling requirement R3.46.

What

  • Added tool_update_text_metrics_updates_bounds
  • Added tool_update_text_metrics_ignores_non_text_nodes
  • Added tool_update_text_metrics_with_max_width
  • Added tool_update_text_metrics_with_parent_managed
  • Updated docs/REQUIREMENTS.md test matrix to reflect coverage.

Why

To improve test coverage for the WASM API bridge and satisfy the requirement R3.46 which was previously untested directly.

Impact

Improves confidence in the text measuring logic within the WASM module without changing actual behavior.

Measurement

Run cargo test --workspace to execute the newly added 4 unit tests.


PR created automatically by Jules for task 8318446655495389111 started by @khangnghiem

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant