π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1240
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1240khangnghiem wants to merge 1 commit into
Conversation
- Added `DOMPurify.sanitize()` when `marked.parse` output is rendered to `innerHTML` in `site/app.js`. - Preserves custom data attributes `data-note-node` and `data-node`. - Appended journal entry in `.jules/sentinel.md` documenting this change. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: The output of
marked.parse(processedNote)was directly appended toinnerHTMLwithout sanitization insite/app.js. This allows an attacker to inject arbitrary HTML and execute cross-site scripting (XSS) if the markdown is parsed from untrusted sources.π― Impact: An attacker could potentially inject malicious scripts into the web application, leading to session hijacking, unauthorized actions on behalf of the user, or defacement of the page.
π§ Fix: Implemented a conditional check to sanitize the rendered markdown using
DOMPurify.sanitize()before injecting it into the DOM. This configuration ensures that standard HTML structure is maintained while stripping out potentially dangerous tags and attributes, but strictly retaining custom attributesdata-note-nodeanddata-node.β Verification: Ran
node --check site/app.jsto ensure valid syntax. Also rancargo check --workspaceandcargo test --workspaceto ensure no related tests failed. Evaluated code structurally to ensure fallback cases were untouched to prevent regression.PR created automatically by Jules for task 10330242291525855005 started by @khangnghiem