Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Markdown rendering#1243

Open
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-xss-markdown-rendering-15003678215010760968
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Markdown rendering#1243
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-xss-markdown-rendering-15003678215010760968

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The output of marked.parse in site/app.js was directly interpolated into innerHTML without sanitization. If window.DOMPurify was unavailable, it failed open by rendering the unsanitized HTML.
🎯 Impact: An attacker could inject malicious scripts or HTML through user-provided Markdown content in notes or other rendered inputs, leading to Cross-Site Scripting (XSS).
πŸ”§ Fix: Sanitized the output of marked.parse(processedNote) using window.DOMPurify.sanitize (allowing specific attributes like data-note-node). Implemented a secure fallback that regex-escapes HTML entities if DOMPurify is unavailable.
βœ… Verification: Ran node --check site/app.js to confirm no syntax errors were introduced. Ran all tests via pnpm lint and pnpm test in the fd-vscode workspace to ensure no regressions. Reviewed the fallback implementation to confirm it does not fail open.


PR created automatically by Jules for task 15003678215010760968 started by @khangnghiem

Ensures that the HTML output of `marked.parse` is sanitized via DOMPurify before being inserted into the DOM. Prevents failing open by safely escaping the text when DOMPurify is unavailable.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant