Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix DOMPurify bypass in markdown parsing#1244

Open
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-marked-xss-app-js-10126509515156068490
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix DOMPurify bypass in markdown parsing#1244
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-marked-xss-app-js-10126509515156068490

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: site/app.js rendered user-provided markdown node notes to HTML via marked.parse without any DOM-level sanitization, making it directly vulnerable to Cross-Site Scripting (XSS) via innerHTML assignment.
🎯 Impact: Arbitrary script execution within the user's browser context if a malicious actor controls the markdown source notes or supplies malicious markdown syntax.
πŸ”§ Fix: Add strict DOMPurify.sanitize conditioning for rendered HTML before assignment. If DOMPurify is unavailable, securely degrade to regex HTML text escaping inside <pre> tags. Added inline security comments.
βœ… Verification: Ran syntax checks via node --check site/app.js and confirmed there are no build regressions by running cargo test --workspace.


PR created automatically by Jules for task 10126509515156068490 started by @khangnghiem

- site/app.js: Added `DOMPurify.sanitize` wrapper when rendering user markdown with `marked.parse()`.
- Add inline code comments explaining security check and fallback mechanism.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant