π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1253
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in markdown rendering#1253khangnghiem wants to merge 1 commit into
Conversation
Sanitizes rendered markdown output using DOMPurify when available, and fails closed to safely escaped plaintext when unavailable, preventing raw unsanitized HTML from being injected into innerHTML. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
π¨ Severity: HIGH
π‘ Vulnerability: The Markdown rendering logic in
site/app.jspassed unsanitized output frommarked.parse()directly intoinnerHTML.π― Impact: Allowed execution of arbitrary JavaScript if a user crafted malicious markdown, leading to Cross-Site Scripting (XSS).
π§ Fix: Implemented conditional DOMPurify sanitization. The application now sanitizes the markdown string before DOM insertion. If DOMPurify is unavailable, the fallback now safely escapes the raw markup instead of "failing open".
β Verification: Ran syntax checks on
site/app.js, verified local testscargo testandpnpm test, and validated code against repository security bounds.PR created automatically by Jules for task 9096514022059591812 started by @khangnghiem